Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add persistent tentant registry #555

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add persistent tentant registry #555

wants to merge 3 commits into from

Conversation

TomasMonkevic
Copy link

@TomasMonkevic TomasMonkevic commented Jun 9, 2023 •
edited
Loading

What is done:

  1. Wired up Redis
  2. Implemented logic of registry repo implementation selection based on environment config

What is still in to do:

  1. Move shutdown field from TenantConsumerInfo class
  2. Implement in memory registry repo (moving the current implementation)
  3. Implement Redis registry repo
  4. Add test with Redis registry repo implementation usage

natansil
natansil reviewed Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@natansil natansil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort @TomasMonkevic!
If no env var is set in the image, will redis run or in-memory run?
Currently with docker-compose, does sidecar connect to redis?

@TomasMonkevic
Copy link
Author

If no env var is set in the image, will redis run or in-memory run?

In-memory will run

Currently with docker-compose, does sidecar connect to redis?

It doesn't because the environment variable isn't provided.

@natansil
Copy link
Collaborator

Cool. sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natansil natansil natansil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasMonkevic @natansil